Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hassio-addon-info feedback #6734

Merged
merged 9 commits into from Sep 3, 2020
Merged

hassio-addon-info feedback #6734

merged 9 commits into from Sep 3, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 29, 2020 •
edited

Proposed change

  • Uses ha-progress-button to give the user feedback when needed.
  • Errors that make sense as a dialog are now in a dialog.
  • Validate config before the start.
  • Fetch info on start action.
  • Add error message extract helper.

NB!: Requires home-assistant/supervisor#1996

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Aug 29, 2020
@ludeeus ludeeus marked this pull request as draft September 3, 2020 08:43
@ludeeus
Copy link
Member Author

ludeeus commented Sep 3, 2020

Needs home-assistant/supervisor#2006

@ludeeus ludeeus marked this pull request as ready for review September 3, 2020 11:08
@ludeeus ludeeus merged commit 5fa0012 into dev Sep 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the hassio-addon-info-feedback branch September 3, 2020 14:39
@bramkragten bramkragten mentioned this pull request Sep 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludeeus @bramkragten @homeassistant