Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Browser Panel #6772

Merged
merged 41 commits into from Sep 4, 2020
Merged

Media Browser Panel #6772

merged 41 commits into from Sep 4, 2020

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Sep 2, 2020 •
edited

Proposed change

image
image
image
image
image
image

Type of change

  • New feature (thank you!)

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

zsarnett
zsarnett commented Sep 2, 2020
View reviewed changes
src/components/ha-sidebar.ts Outdated Show resolved Hide resolved
zsarnett
zsarnett commented Sep 2, 2020
View reviewed changes
src/panels/media-browser/ha-panel-media-browser.ts Outdated
Comment on lines 38 to 40
// @ts-ignore
@LocalStorage("mediaBrowseEntityId")
private _entityId?: string;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need help from Bram on this decorator so that InternalProperty can be use at the same time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6776

zsarnett
zsarnett commented Sep 2, 2020
View reviewed changes
src/panels/media-browser/ha-panel-media-browser.ts Outdated
mediaSources: this._browseMediaSources(this.hass),
sourceSelectedCallback: (entityId) => {
this._entityId = entityId;
this.requestUpdate();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

@zsarnett zsarnett marked this pull request as draft September 2, 2020 20:33
zsarnett and others added 2 commits September 4, 2020 13:41
@zsarnett @bramkragten
Update src/components/ha-dialog.ts
a46d4e5 
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@zsarnett
comments
227db34
bramkragten
bramkragten reviewed Sep 4, 2020
View reviewed changes
src/components/ha-hls-player.ts Show resolved Hide resolved
src/components/ha-hls-player.ts Outdated Show resolved Hide resolved
@bramkragten bramkragten merged commit e63a78b into dev Sep 4, 2020
@bramkragten bramkragten deleted the media-browser-panel branch September 4, 2020 21:01
@bramkragten bramkragten mentioned this pull request Sep 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
cla-signed wait for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zsarnett @bramkragten @homeassistant