Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize reloadableDomains #6773

Merged
merged 2 commits into from Sep 3, 2020
Merged

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Sep 3, 2020

Proposed change

This cuts out the manual having to add domains to the reloadableDomains array and having to add translations for every domain. The default translation can still be overwritten.

Also allows custom integrations to show up in the reload list.

/CC @bdraco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

"history_stats": "Reload history stats entities",
"trend": "Reload trend entities",
"ping": "Reload ping binary sensor entities",
"filesize": "Reload file size entities"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the translations that do not result in an identical string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can, should we leave all in? They all are slightly different I think, mainly because of plurals

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, why not.
We can always change it / remove some in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bramkragten if possible please add rpi_gpio to the translations (https://github.com/home-assistant/frontend/pull/6764/files#diff-571ce32a17d6aa22fdd0942224a8ff44R856)

"rpi_gpio": "Reload Raspberry Pi GPIO entities"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it say now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it needs to change, please create a PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, there is no rpi_gpio entry.
I'll check how this looks and if needed create a new PR.

@bramkragten bramkragten merged commit d16e2f3 into dev Sep 3, 2020
@bramkragten bramkragten deleted the generalize-reloadable-domains branch September 3, 2020 13:24
@bramkragten bramkragten mentioned this pull request Sep 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants