New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize reloadableDomains #6773
Conversation
src/translations/en.json
Outdated
"history_stats": "Reload history stats entities", | ||
"trend": "Reload trend entities", | ||
"ping": "Reload ping binary sensor entities", | ||
"filesize": "Reload file size entities" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the translations that do not result in an identical string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we can, should we leave all in? They all are slightly different I think, mainly because of plurals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, why not.
We can always change it / remove some in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bramkragten if possible please add rpi_gpio to the translations (https://github.com/home-assistant/frontend/pull/6764/files#diff-571ce32a17d6aa22fdd0942224a8ff44R856)
"rpi_gpio": "Reload Raspberry Pi GPIO entities"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it say now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it needs to change, please create a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, there is no rpi_gpio entry.
I'll check how this looks and if needed create a new PR.
Proposed change
This cuts out the manual having to add domains to the
reloadableDomains
array and having to add translations for every domain. The default translation can still be overwritten.Also allows custom integrations to show up in the reload list.
/CC @bdraco
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: