Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node details shortcut to OZW device pages #6791

Merged
merged 4 commits into from Sep 4, 2020

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Sep 4, 2020

Proposed change

Adds a "Node Details" button to the device pages for OZW devices that takes you to the details page for that node in the OZW config panel. Also fixes a translation for the Refresh Node button.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@cgarwood
Copy link
Member Author

cgarwood commented Sep 4, 2020

image

Comment on lines 88 to 93
<mwc-button @click=${this._nodeDetailsClicked}>
${this.hass.localize("ui.panel.config.ozw.node.button")}
</mwc-button>
<mwc-button @click=${this._refreshNodeClicked}>
Refresh Node
${this.hass.localize("ui.panel.config.ozw.refresh_node.button")}
</mwc-button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in device actions, so it is styled correctly. Check zha for example.

@bramkragten bramkragten merged commit fcc22ba into home-assistant:dev Sep 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants