Display services as services and not devices #6798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Sep 5, 2020
Comment on lines
+199
to
201
| ${(devices.length || services.length) && entities.length | ||
| ? this.hass.localize("ui.common.and") | ||
| : ""} |
There was a problem hiding this comment.
We should also render an and when there is both a service and a device.
There was a problem hiding this comment.
I had that first, but if the integration has both you end up with:
"x services and x devices and x entities" which feels weird 🤷
Add a comma maybe?
There was a problem hiding this comment.
yeah:
2 devices, 1 service and 5 entities
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Sep 5, 2020
Comment on lines
186
to
188
| : ""} | ||
| ${devices.length || services.length ? "," : ""} | ||
| ${services.length |
There was a problem hiding this comment.
Suggested change
| : ""} | |
| ${devices.length || services.length ? "," : ""} | |
| ${services.length | |
| : ""}${devices.length && services.length ? "," : ""} | |
| ${services.length |
bramkragten
approved these changes
Sep 5, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Display services as services and not devices
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: