Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media browser updates #6801

Merged
merged 4 commits into from
Sep 6, 2020
Merged

Media browser updates #6801

merged 4 commits into from
Sep 6, 2020

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Sep 6, 2020

Proposed change

Add sorting to sort folders first and then by title

Creates an error box if we receive an error when browsing (ex. user tries to browse a file that doesn't exist. This can be achieved if the user browses using the media browser and then deletes the file and tries to browse to it)

fixes the position of the dialog on the screen so that the top of the dialog stays at the same spot and only the height changes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment on lines 416 to 420
: first.title > second.title
? 1
: second.title > first.title
? -1
: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zsarnett zsarnett merged commit efe8eca into dev Sep 6, 2020
@zsarnett zsarnett deleted the media-browser-updates branch September 6, 2020 23:28
@bramkragten bramkragten mentioned this pull request Sep 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants