Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media browser panel title + selection header color #6807

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Sep 6, 2020

Breaking change

Proposed change

Adds proper translation key for the media browser panel. This is related to the core PR home-assistant/core#39720 that ensures the proper key is used for the panel title.

This PR also fixes the wrong color of the heading of the "Choose Player" dialog (was using black also in dark mode).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit cfa0c45 into home-assistant:dev Sep 6, 2020
@spacegaier spacegaier deleted the media-browser branch September 6, 2020 22:12
@bramkragten bramkragten mentioned this pull request Sep 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants