Handle media browser errors #6813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
commented
Sep 7, 2020
| @@ -92,11 +94,54 @@ export class HaMediaPlayerBrowse extends LitElement { | |||
| this._navigate(item); | |||
| } | |||
|
|
|||
| private _renderError(err: { message: string; code: string }) { | |||
| if (err.message === "Path does not exist.") { | |||
There was a problem hiding this comment.
After a backend change this should be:
Suggested change
| if (err.message === "Path does not exist.") { | |
| if (err.code === "no_media_folder") { |
ludeeus
reviewed
Sep 7, 2020
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
ludeeus
reviewed
Sep 7, 2020
| <p> | ||
| Check the | ||
| <a | ||
| href="https://www.home-assistant.io/integrations/media_source/#local-media" |
There was a problem hiding this comment.
Should we use the RC site if the version contains a "b" here?
This will go to a non-exsisting site during the beta
There was a problem hiding this comment.
If we do that, we should get a helper method and apply that everywhere. I think it's fine for now.
zsarnett
reviewed
Sep 7, 2020
zsarnett
approved these changes
Sep 7, 2020
Merged
9 tasks
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Handle media browsers better, so it doesn't break the UI and we explain the user how he can make it work.
Needs home-assistant/core#39759
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: