Media Browser: Use Media Class #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
bramkragten
reviewed
Sep 10, 2020
| class="children ${classMap({ | ||
| portrait: mediaClass.thumbnail_ratio === "portrait", | ||
| })}" | ||
| > | ||
| ${currentItem.children.map( | ||
| (child) => html` |
There was a problem hiding this comment.
Suggested change
| (child) => html` | |
| (child) => { const classStyles = MediaClassBrowserSettings[child.media_class]; return html` |
There was a problem hiding this comment.
Not sure what you are going for here
There was a problem hiding this comment.
There are no per child classes needed
There was a problem hiding this comment.
You keep looking up the MediaClassBrowserSettings, do it once and store in a var.
|
Need to fix safari rendering in this PR as well |
|
Also I should fix this #6946 |
|
Going to fix this too #6949 EZ fix |
|
@bramkragten I cant figure out the damn safari bug right now. Also, its late and Friday. and beers so |
21 tasks
bramkragten
reviewed
Sep 12, 2020
bramkragten
reviewed
Sep 12, 2020
bramkragten
reviewed
Sep 12, 2020
bramkragten
approved these changes
Sep 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist