Expand groups in entitry row to check toggle #6930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Sep 11, 2020
| private _computeCanToggle = memoizeOne( | ||
| (hass: HomeAssistant, entityIds: string[]): boolean => { | ||
| return entityIds.some((entityId) => { | ||
| const domain = entityId.split(".", 1)[0]; |
There was a problem hiding this comment.
Suggested change
| const domain = entityId.split(".", 1)[0]; | |
| const domain = computeDomain(entityId); |
bramkragten
approved these changes
Sep 11, 2020
bramkragten
reviewed
Sep 11, 2020
| @@ -22,6 +23,21 @@ class HuiGroupEntityRow extends LitElement implements LovelaceRow { | |||
|
|
|||
| @internalProperty() private _config?: EntityConfig; | |||
|
|
|||
| private _computeCanToggle = memoizeOne( | |||
| (hass: HomeAssistant, entityIds: string[]): boolean => { | |||
There was a problem hiding this comment.
Just see you made a memoize from it, but you pass hass, that means it will still update on every state change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: