Show which state changed events a template listeners for in dev tools #6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Sep 11, 2020
bramkragten
reviewed
Sep 11, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 11, 2020
bramkragten
reviewed
Sep 11, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
|
Retest:
|
|
Revised the no listeners case as that will probably get some people.
|
|
Retested markdown card
|
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
approved these changes
Sep 11, 2020
|
Wait for backend pending the decision to cherry-pick home-assistant/core#39925 or not |
|
Going to test with #39925 reverted to make sure it works when we don't get listeners. |
|
Verified doesn't error without home-assistant/core#39925 and still works with it |
bramkragten
reviewed
Sep 11, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
|
Retested, looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires home-assistant/core#39925
Proposed change
Show which state changed events a template listeners for in dev tools
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: