Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --error-color instead of a fixed color #6961

Merged
merged 4 commits into from Sep 14, 2020

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Sep 12, 2020

Proposed change

This makes the error-card use --error-color as the background color, instead of a set one, so you can theme it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

frontend:
  themes:
    errorblues:
      error-color: blue

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@KTibow KTibow marked this pull request as ready for review September 12, 2020 18:42
src/panels/lovelace/cards/hui-error-card.ts Outdated Show resolved Hide resolved
@zsarnett zsarnett self-requested a review September 13, 2020 20:40
Co-authored-by: Zack Barett <zackbarett@hey.com>
@bramkragten bramkragten merged commit f6eb31b into home-assistant:dev Sep 14, 2020
@bramkragten bramkragten mentioned this pull request Sep 15, 2020
@KTibow KTibow deleted the patch-4 branch September 16, 2020 01:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants