-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quickbar debounce #7426
Fix quickbar debounce #7426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a this._search = ""
to closeDialog()
Edit Went ahead and pushed the change.
@@ -79,6 +81,7 @@ export class QuickBar extends LitElement { | |||
this._done = false; | |||
this._focusSet = false; | |||
this._filter = ""; | |||
this._search = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this so the previous filter would clear before launching the dialog again.
* Fix quicbar debounce * Clear search property when dialog is closed Co-authored-by: Donnie <donniekarnsinsb@hotmail.com>
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: