Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quickbar debounce #7426

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Fix quickbar debounce #7426

merged 2 commits into from
Oct 22, 2020

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Oct 21, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@donkawechico donkawechico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Copy link
Contributor

@donkawechico donkawechico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a this._search = "" to closeDialog()

Edit Went ahead and pushed the change.

@@ -79,6 +81,7 @@ export class QuickBar extends LitElement {
this._done = false;
this._focusSet = false;
this._filter = "";
this._search = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this so the previous filter would clear before launching the dialog again.

@bramkragten bramkragten merged commit 211ab4e into dev Oct 22, 2020
@bramkragten bramkragten deleted the fix-quick-bar-debounce branch October 22, 2020 09:00
@bramkragten bramkragten added this to the 0.117.0 milestone Oct 22, 2020
bramkragten added a commit that referenced this pull request Oct 22, 2020
* Fix quicbar debounce

* Clear search property when dialog is closed

Co-authored-by: Donnie <donniekarnsinsb@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants