-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid fetching logbook data instead in addition to not displaying it #7427
Merged
bramkragten
merged 9 commits into
home-assistant:dev
from
bdraco:logbook_entries_still_fetched
Oct 22, 2020
Merged
Avoid fetching logbook data instead in addition to not displaying it #7427
bramkragten
merged 9 commits into
home-assistant:dev
from
bdraco:logbook_entries_still_fetched
Oct 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsarnett
reviewed
Oct 22, 2020
zsarnett
reviewed
Oct 22, 2020
We could also prevent the |
I reverted the original change and moved it into |
bramkragten
approved these changes
Oct 22, 2020
bramkragten
pushed a commit
that referenced
this pull request
Oct 22, 2020
…7427) Co-authored-by: Zack Barett <zackbarett@hey.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
#7239 fixed the logbook data being displayed when there was never going to be
any, but I failed to realize that it was still fetching the data and generating
a database query on the backend 🤦
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: