Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fetching logbook data instead in addition to not displaying it #7427

Merged
merged 9 commits into from
Oct 22, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2020

Proposed change

#7239 fixed the logbook data being displayed when there was never going to be
any, but I failed to realize that it was still fetching the data and generating
a database query on the backend 🤦

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

We could also prevent the ha-more-info-logbook to render in the more-info dialog?

@bdraco
Copy link
Member Author

bdraco commented Oct 22, 2020

I reverted the original change and moved it into ha-more-info-dialog

@bramkragten bramkragten merged commit eceed4e into home-assistant:dev Oct 22, 2020
bramkragten pushed a commit that referenced this pull request Oct 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants