-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quick bar dark mode contrast, filter returning all items, no primary text #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
donkawechico
changed the title
Fix dark mode selection contrast and sequence filter returning all items
Fix dark mode item contrast, filter returning all items, no primary text
Oct 22, 2020
donkawechico
changed the title
Fix dark mode item contrast, filter returning all items, no primary text
Fix dark mode contrast, filter returning all items, no primary text
Oct 22, 2020
donkawechico
changed the title
Fix dark mode contrast, filter returning all items, no primary text
Fix quick bar dark mode contrast, filter returning all items, no primary text
Oct 22, 2020
9 tasks
bramkragten
reviewed
Oct 22, 2020
The contrast being too low in dark mode is not a quick bar only issue, but for every |
bramkragten
reviewed
Oct 22, 2020
bramkragten
reviewed
Oct 22, 2020
donkawechico
force-pushed
the
quick-bar-fix-filter-and-theming
branch
from
October 22, 2020 17:37
a213b0f
to
d5c4d73
Compare
donkawechico
force-pushed
the
quick-bar-fix-filter-and-theming
branch
from
October 22, 2020 21:21
223a37a
to
b807957
Compare
donkawechico
force-pushed
the
quick-bar-fix-filter-and-theming
branch
from
October 22, 2020 21:39
b807957
to
815e308
Compare
bramkragten
reviewed
Oct 22, 2020
bramkragten
reviewed
Oct 22, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Oct 22, 2020
bramkragten
approved these changes
Oct 22, 2020
bramkragten
added a commit
that referenced
this pull request
Oct 22, 2020
…ary text (#7430) Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes a few regressions caused by #7359:
...and an unrelated but minor bug discovered after beta release:
3. List item primary text showing nothing when friendly name is empty string
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: