Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick bar dark mode contrast, filter returning all items, no primary text #7430

Merged
merged 6 commits into from
Oct 22, 2020

Conversation

donkawechico
Copy link
Contributor

@donkawechico donkawechico commented Oct 22, 2020

Proposed change

Fixes a few regressions caused by #7359:

  1. List item selection highlight not high enough contrast
  2. Sequence filter returning all other items after the highest-scored item

...and an unrelated but minor bug discovered after beta release:
3. List item primary text showing nothing when friendly name is empty string

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico changed the title Fix dark mode selection contrast and sequence filter returning all items Fix dark mode item contrast, filter returning all items, no primary text Oct 22, 2020
@donkawechico donkawechico changed the title Fix dark mode item contrast, filter returning all items, no primary text Fix dark mode contrast, filter returning all items, no primary text Oct 22, 2020
@donkawechico donkawechico changed the title Fix dark mode contrast, filter returning all items, no primary text Fix quick bar dark mode contrast, filter returning all items, no primary text Oct 22, 2020
@donkawechico
Copy link
Contributor Author

donkawechico commented Oct 22, 2020

There's still a bug with topmost item selection not showing hover color when input field has focus.

image

The first item should have hover color on because it's selectable by hitting enter. I wasn't able to find a fix using the this_setFocusFirstListItem() method.

@bramkragten
Copy link
Member

The contrast being too low in dark mode is not a quick bar only issue, but for every mwc-list so we should fix it for all.

@donkawechico donkawechico force-pushed the quick-bar-fix-filter-and-theming branch from a213b0f to d5c4d73 Compare October 22, 2020 17:37
@bramkragten bramkragten added this to the 0.117.0 milestone Oct 22, 2020
@donkawechico donkawechico force-pushed the quick-bar-fix-filter-and-theming branch from 223a37a to b807957 Compare October 22, 2020 21:21
@donkawechico donkawechico force-pushed the quick-bar-fix-filter-and-theming branch from b807957 to 815e308 Compare October 22, 2020 21:39
donkawechico and others added 2 commits October 22, 2020 14:41
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit a78c00f into dev Oct 22, 2020
@bramkragten bramkragten deleted the quick-bar-fix-filter-and-theming branch October 22, 2020 22:06
bramkragten added a commit that referenced this pull request Oct 22, 2020
…ary text (#7430)

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants