Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow for "progress" step #7592

Merged
merged 1 commit into from Nov 9, 2020
Merged

Add flow for "progress" step #7592

merged 1 commit into from Nov 9, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 4, 2020

Breaking change

Proposed change

Adds "progress" flow step for home-assistant/core#42419

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

image

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment on lines +63 to +67
flow_id: string;
handler: string;
step_id: string;
progress_action: string;
description_placeholders: { [key: string]: string };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bring the general fields to a generic type someday, they all have flow_id, handler, step_id and description_placeholders

@MartinHjelmare
Copy link
Member

Backend PR is merged.

@bramkragten bramkragten merged commit 6ae67ed into dev Nov 9, 2020
@bramkragten bramkragten deleted the progress-step branch November 9, 2020 21:45
KTibow pushed a commit to KTibow/frontend-1 that referenced this pull request Nov 10, 2020
KTibow added a commit to KTibow/frontend-1 that referenced this pull request Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants