New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide stub config for entity-filter #8121
Conversation
In #7637 I went for the simplest possible stub: |
Nothing really happens. It is just as if the entity was filtered. Your version for sure makes sense as the stub for a real GUI editor, since there the user does not need to thing about any YAML structure. |
The stub should always be the most simple config, so I think the suggestion from Thomas works. |
That's a good point. But maybe we should have it pick a few entities at random instead? Like the entities card does. |
That was my initial thought as well, but wasn't sure what filter states to choose? That's why I went with sun which usually exists, although its state filter is only hit during half of the day. So double not ideal indeed. We could just select three random binary_sensors and set card filter state to "on". There is a decent change at least one of the randomly picked sensors is "on" so that the user sees an entity in the card preview, although that is nice to have. |
You could pick the current state of the first entity as the filter? |
Breaking change
Proposed change
Void in case #7637 gets merged soon.
Currently, if you add an entity-filter you are greeted by the YAML editor in an error state, because mandatory config keys are missing. With this PR we now provide something meaningful as a starting point.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: