New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple tap/hold/doubletap actions. #8125
Conversation
I'll take this back to the drawing board for a while. Besides the merge conflict, confirmations can now only be applied to the individual actions inside the |
@@ -41,7 +41,11 @@ export const handleAction = async ( | |||
} | |||
|
|||
const actionConfigs = | |||
actionConfig.action === "multiple" ? actionConfig.actions : [actionConfig]; | |||
actionConfig.action === "multiple" | |||
? Array.isArray(actionConfig.actions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How I googled for this, which I assumed must be in js/ts somewhere. Should have git greped...
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Add a new action type - multiple, which takes a list of
actions:
and perform them all.Use case is e.g. if you have a layout like this https://www.youtube.com/watch?v=5y6rhwr5Y8c you may want to activate a script and get back to the start view with a single tap.
I was a bit worried about the maintenance burden, but with all the type checking it turns out to be only four lines of business logic in
handle-action.ts
and a single special case to handle inhui-action-editor.ts
- which is all special cases already...Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: