Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number slider: change column width check from 350px to 300px #8310

Merged
merged 1 commit into from Sep 6, 2021

Conversation

sVnsation
Copy link
Contributor

Proposed change

Change check on column width from 350px -> 300px to hide certain elements.

The problem with 350 is, that it is most of the time to big and the state most of the time hidden, because the responsive column change is on 300. So just before reaching 350/directly after 300 you will get another column with again below 350.

See Screenshots here #8050 (comment) and here #8050 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

Copy link
Contributor

@emufan emufan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you took this over.

@bramkragten
Copy link
Member

Can you add a screenshot for the width of 300px with different entity names?

@andrist
Copy link
Contributor

andrist commented Feb 21, 2021

Looks good to me.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 22, 2021
@andrist
Copy link
Contributor

andrist commented May 22, 2021

Bump

@github-actions github-actions bot removed the stale label May 22, 2021
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 20, 2021
@andrist
Copy link
Contributor

andrist commented Aug 20, 2021

Bump

@github-actions github-actions bot removed the stale label Aug 20, 2021
@bramkragten bramkragten merged commit 1073dbe into home-assistant:dev Sep 6, 2021
@spacegaier spacegaier mentioned this pull request Sep 6, 2021
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants