Show the reason why an add-on is not available #8312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
reviewed
Feb 3, 2021
Comment on lines
181
to
182
| The architecture on your system | ||
| (${this.supervisor.supervisor.arch}) is no longer |
There was a problem hiding this comment.
I wonder if this should be more user-facing in text.
For example:
This add-on is not compatible with the processor of your device or the operating system you have installed on your device.
There was a problem hiding this comment.
So not display archs at all?
bramkragten
reviewed
Feb 3, 2021
bramkragten
reviewed
Feb 3, 2021
bramkragten
reviewed
Feb 3, 2021
bramkragten
approved these changes
Feb 3, 2021
ludeeus
force-pushed
the
unavailable-reason
branch
from
7849869
to
1c0dd48
Compare
bramkragten
reviewed
Feb 3, 2021
bramkragten
reviewed
Feb 3, 2021
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Feb 3, 2021
bramkragten
reviewed
Feb 3, 2021
bramkragten
approved these changes
Feb 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Show the reason why an add-on is not available
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: