Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use websockets #8403

Merged
merged 23 commits into from
Feb 18, 2021
Merged

Use websockets #8403

merged 23 commits into from
Feb 18, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Feb 16, 2021

Breaking change

Proposed change

  • Uses WebSockets for API calls where we can.
  • Adds event listener so the Supervisor can signal updates to the frontend.
  • Extends atLeastVersion to check 3 sections

Needing to keep backward compatibility sucks...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Feb 16, 2021
bramkragten
bramkragten previously approved these changes Feb 16, 2021
ludeeus and others added 3 commits February 16, 2021 20:58
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@ludeeus ludeeus merged commit 09e7600 into dev Feb 18, 2021
@ludeeus ludeeus deleted the su-ws branch February 18, 2021 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supervisor.snapshots complains about double snapshot request
3 participants