Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom UI for full cards and more info cards #850

Closed
wants to merge 1 commit into from
Closed

Custom UI for full cards and more info cards #850

wants to merge 1 commit into from

Conversation

c727
Copy link
Contributor

@c727 c727 commented Jan 30, 2018 •
edited
Loading

andrey-git
andrey-git approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@andrey-git andrey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine. Deferring to @balloob to merge though

@c727 c727 mentioned this pull request Feb 9, 2018
Closed
@c727
Copy link
Contributor Author

c727 commented Feb 10, 2018

I think I will change this again and move the code for custom UI out of the state attributes

@andrey-git
Copy link
Contributor

Currently there is no other place to put it.

@c727
Copy link
Contributor Author

c727 commented Feb 10, 2018

As suggested here home-assistant/core#10732 (comment) I will try to move the code from customize to something like frontend: entity_config:

So we use customize only for core features like friendly name or icon

@c727
Copy link
Contributor Author

c727 commented Mar 13, 2018 •
edited
Loading

@balloob
Do we want to add this now (new keys in customize:) or close this PR and wait until custom UIs are added to entity registry?

If we want to add it now I will update the code according the latest file changes

@balloob
Copy link
Member

balloob commented Mar 13, 2018

I suggest we wait for the frontend to be refactored.

@balloob balloob closed this Mar 13, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrey-git andrey-git andrey-git approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c727 @andrey-git @balloob @homeassistant