Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use "media_play_pause" but atomic services instead #8845

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Currently we are using the service media_play_pause to start media playback. Since there are however media players that do not support pausing, they do not have that service implemented and therefore the playback cannot be started.

With this PR we now use the atomic media_play instead and pause via media_pause if supported by the player.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier marked this pull request as ready for review April 8, 2021 08:51
@spacegaier spacegaier merged commit de72643 into home-assistant:dev Apr 8, 2021
@spacegaier spacegaier deleted the issue-8672 branch April 8, 2021 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mediaplayer card sending "media_play_pause" instead of "media_play"
3 participants