Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and format timestamp attributes #9074

Merged
merged 12 commits into from
May 25, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented May 2, 2021

Breaking change

Proposed change

Ensures that timestamps in more-info popus for attributes are properly formatted.

One point to discuss:

  • The RegExp I use also matches pure dates without a time element (but not the other way around) => should I add a second RegExp that then checks if it is a pure date and then we call formatDate rather than formatDateTimeWithSeconds as I do currently?
  • Adjust the RegExp to not match dates, which solves the point above.
  • Added 2nd RegExp for date detection and formatting.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier merged commit 3d4d789 into home-assistant:dev May 25, 2021
@spacegaier spacegaier deleted the attr-timestamp-formatting branch May 25, 2021 20:39
@bramkragten bramkragten mentioned this pull request May 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants