Silence babel warnings #9158
Merged
Silence babel warnings #9158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
commented
May 10, 2021
| { loose: true }, | ||
| ], | ||
| ["@babel/plugin-proposal-decorators", { decoratorsBeforeExport: true }], | ||
| ["@babel/plugin-proposal-private-methods", { loose: true }], |
There was a problem hiding this comment.
This is the line that is actually changed
There was a problem hiding this comment.
We used loose because previously that was the only way we could get decorators to work or something.
balloob
reviewed
May 10, 2021
| @@ -53,13 +54,13 @@ module.exports.babelOptions = ({ latestBuild }) => ({ | |||
| babelrc: false, | |||
| presets: [ | |||
| !latestBuild && [ | |||
| require("@babel/preset-env").default, | |||
| "@babel/preset-env", | |||
There was a problem hiding this comment.
we used to do this because of some things didn't manage to resolve. Glad it works now.
balloob
approved these changes
May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Not sure why we use the
looseoption, but we should use it for everything if we want to use it.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: