Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace fixes #9192

Merged
merged 5 commits into from May 17, 2021
Merged

Trace fixes #9192

merged 5 commits into from May 17, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented May 17, 2021

Breaking change

Proposed change

  • Render all trace results between current shown node and the next rendered node. This will include all sub-conditions
  • Timeline no longer crashes on complicated choose nodes
  • Timeline no longer shows entries for things like sub-conditions that it doesn't handle
  • Errors in timeline are now better shown

Fix showing subconditions
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob marked this pull request as draft May 17, 2021 16:10
@balloob
Copy link
Member Author

balloob commented May 17, 2021

Converting to draft as I believe it's a bug

image

@balloob balloob changed the title Show sub-conditions Render all trace results between current path and next rendered path. May 17, 2021
@balloob balloob marked this pull request as ready for review May 17, 2021 16:56
@balloob balloob changed the title Render all trace results between current path and next rendered path. Trace fixes May 17, 2021
@balloob
Copy link
Member Author

balloob commented May 17, 2021

The bug is still there but it no longer impacts this PR, so PR is ready for review.

@bramkragten bramkragten merged commit f8e8b5a into dev May 17, 2021
@bramkragten bramkragten deleted the show-sub-conditions branch May 17, 2021 18:19
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants