Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cutting off of attributes in more-info light #9219

Merged
merged 2 commits into from
May 25, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@@ -552,7 +552,6 @@ class MoreInfoLight extends LitElement {

.content > * {
width: 100%;
max-height: 84px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right solution, I remember it was there for a reason... Will check... We could at least remove max-height from ha-attributes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, seems not to be used anymore 🤷‍♂️

@bramkragten bramkragten merged commit 2b8033a into home-assistant:dev May 25, 2021
@spacegaier spacegaier deleted the issue-9218 branch May 25, 2021 18:55
@bramkragten bramkragten mentioned this pull request May 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Details light domain cut off
3 participants