New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh snapshot create/restore dialogs #9223

Merged

ludeeus merged 13 commits into dev from sn-create-restore

May 25, 2021

Member

ludeeus commented May 21, 2021 •

edited

Breaking change

Proposed change

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion: Toggle All/None in Restore panel #7502
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

ludeeus added 2 commits

May 21, 2021 13:20


          Refresh snapshot create/restore dialogs

52c871d


          Clear _errror

c5072f1

ludeeus added the Supervisor label

homeassistant added the cla-signed label

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

ludeeus and others added 5 commits

May 25, 2021 07:55


          update

98ac4c4


          Add supervisor-formfield-label

0132e82


          Update supervisor-snapshot-content.ts

a252fbe


          limit loops

1ec7a36


          intersept closing event

b06dae3

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved


          Fix section entry updates

bb0eecd

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

ludeeus and others added 4 commits

May 25, 2021 13:51


          Update hassio/src/components/supervisor-snapshot-content.ts

99245dc

Co-authored-by: Bram Kragten <mail@bramkragten.nl>


          Prettier

31d9f41


          fix style

6e4e91e


          simplify logic

d06febd

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts

+                public willUpdate(changedProps) {
+                  super.willUpdate(changedProps);
+                  if (!this.hasUpdated) {

Member

bramkragten May 25, 2021

Should we update this if snapshot or supervisor.addons changes?

Member Author

ludeeus May 25, 2021

I don't think that is needed, hasUpdated is false every time you open the dialog

bramkragten reviewed

View reviewed changes

hassio/src/components/supervisor-snapshot-content.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/dialogs/snapshot/dialog-hassio-snapshot.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/dialogs/snapshot/dialog-hassio-create-snapshot.ts Outdated Show resolved Hide resolved

bramkragten reviewed

View reviewed changes

hassio/src/dialogs/snapshot/dialog-hassio-snapshot.ts Outdated Show resolved Hide resolved


          Add snapshotDetails

77de3f5

bramkragten approved these changes

View reviewed changes

ludeeus merged commit 0dd3757 into dev

ludeeus deleted the sn-create-restore branch

May 25, 2021 19:29

bramkragten mentioned this pull request

20210526.0 #9267

Merged

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.