Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rotate chart axis labels #9329

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jun 1, 2021

Proposed change

I don't have a strong opinion about this, I slightly prefer not rotated labels, it gives more space to the chart, and it also is a bit faster...

Before:

image

After:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 1795fd5 into dev Jun 1, 2021
@balloob balloob deleted the dont-rotate-chart-axis-labels branch June 1, 2021 17:28
@bramkragten bramkragten mentioned this pull request Jun 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants