Align internal and fecha date/time formatting #9380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
I noticed that on Win 10 my FF browser for timestamps in the first hours of the day shows a leading zero for the hour e.g. 08:15. Our internal formatting does not do that, but
fecha
does (so it looks like the internal formatting is not supported there any more?). In Chrome however, I do not see that leading zero, meaning the internal formatting is used instead offecha
.This PR now aligns the formatting to be consistent between the two. This means that for the 24 hour format we will show two digit hour values. For AM/PM format we will not as that seems to be the customary format and
fecha
also does not add the leading zero there (probably because with "AM" or "PM" at the end it is already long enough).Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: