Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chartjs to version 3 #9401

Merged
merged 8 commits into from Jun 18, 2021
Merged

Bump chartjs to version 3 #9401

merged 8 commits into from Jun 18, 2021

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jun 10, 2021

Proposed change

Upgrade chartjs to version 3.

Todo:

  • Dynamic import
  • Tooltips
  • Title / legends
  • Fine tuning

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

src/resources/ha-style.ts Outdated Show resolved Hide resolved
src/components/chart/timeline-chart/const.ts Outdated Show resolved Hide resolved
src/components/chart/timeline-chart/timeline-scale.ts Outdated Show resolved Hide resolved
src/components/chart/state-history-chart-timeline.ts Outdated Show resolved Hide resolved
src/components/chart/state-history-chart-timeline.ts Outdated Show resolved Hide resolved
src/components/chart/chart-date-adapter.ts Outdated Show resolved Hide resolved
src/components/chart/chart-date-adapter.ts Outdated Show resolved Hide resolved
@bramkragten bramkragten merged commit 0ef3421 into dev Jun 18, 2021
@bramkragten bramkragten deleted the bump-chartjs branch June 18, 2021 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants