Add Z-Wave JS Heal Node wizard #9562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 tasks
bramkragten
reviewed
Jul 19, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-heal-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jul 19, 2021
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-heal-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jul 19, 2021
| this.entry_id! | ||
| ); | ||
| if (network.controller.is_heal_network_active) { | ||
| this._status = "network-healing"; |
There was a problem hiding this comment.
Since we are not waiting for the network fetch call, technically a user could now start a new heal when one is still active.
There was a problem hiding this comment.
If you try to start a new heal while one is in progress the server will reject it, so our error handler will catch it.
bramkragten
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a dialog wizard to Z-Wave JS devices to heal the device.
Untitled.Project.mp4
Type of change
Example configuration
Checklist
If user exposed functionality or configuration variables are added/changed: