Pass the width and height when requesting camera images

[bdraco]

Proposed change

Pass the width and height when requesting camera images

Requires home-assistant/core#53835

Testing:

• Tested with Chrome with network throttling to fast 3g. Cameras are now usable
• Tested with mobile device with poor service. Cameras are now usable

Additional improvement would be to not update cameras that are not inside the viewport, but that is outside the scope of this PR because even with this change there are timeouts on slow 3g (#9690).

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bdraco]

It is working with width and height but I had to change the typing here. Not sure this it the best solution.

[balloob]

I tried locally but couldn't figure it out. It's all good.

[balloob]

One thing I did just realize after I merged it (ofc), we will cache by entity ID and not by width/height. So there might be cases where a user caches a smaller image and so the new bigger location will serve from the cache.

[bdraco]

I'm likely missing something here. If I load two windows, I see them get different size images.

[bdraco]

I tried loading the smaller one first, then refreshing the bigger one but still got the larger image. I'm missing something

[bramkragten]

We don't cache these files, otherwise the image would never move

[bdraco]

Thanks. I thought it might have something to do with #9690 merged in to my test branch, but that didn't make sense.

[bramkragten]

Well we do cache within the session, but not in another screen/window/refresh, and we also only cache for 9 seconds...

So it could be an issue if you have the same entity on your page twice in different sizes I guess...

[bramkragten]

To fix that, we should replace entityId in timeCachePromiseFunc with an itemKey and include both the entity id and size in that.

[bdraco]

I'll open something for that shortly

[bdraco]

To fix that, we should replace entityId in timeCachePromiseFunc with an itemKey and include both the entity id and size in that.

#9778