Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons for the device_class 'update' #9711

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Add icons for the device_class 'update' #9711

merged 3 commits into from
Aug 16, 2021

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Aug 4, 2021

Proposed change

This will add mdi:update as fixed icon for device class DEVICE_CLASS_UPDATE

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@mib1185 mib1185 marked this pull request as ready for review August 15, 2021 19:32
ludeeus
ludeeus reviewed Aug 15, 2021
View reviewed changes
src/common/const.ts Outdated Show resolved Hide resolved
@mib1185 mib1185 requested a review from ludeeus August 15, 2021 20:21
@ludeeus ludeeus changed the title Add fixed icon for device class update Add icons for the device_class 'update' Aug 16, 2021
ludeeus
ludeeus approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Can be merged once the core PR has been merged

@frenck frenck merged commit 7aa2ec7 into home-assistant:dev Aug 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2021
@mib1185 mib1185 deleted the binary_sensor/add-device-class-update branch October 8, 2023 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthiasdebaat matthiasdebaat matthiasdebaat left review comments

@ludeeus ludeeus ludeeus approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mib1185 @ludeeus @matthiasdebaat @frenck @homeassistant