Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracing graph #9782

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Fix tracing graph #9782

merged 1 commit into from
Aug 12, 2021

Conversation

bramkragten
Copy link
Member

Proposed change

  • Set a fixed with and height to graph node, so we don't have to wait on rendering for it to have a size.
  • Remove host-context it is badly supported by browsers, and doesn't work well (activates too much) if it is embedded in another branch

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 44548fd into dev Aug 12, 2021
@bramkragten bramkragten deleted the fix-tracing-graph branch August 12, 2021 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants