Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integration manifest for service documentation URL #9960

Merged
merged 4 commits into from Sep 6, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Use the integration manifest for the service documentation, so that it also works for custom integrations.

If the user just switches to a different service from the same domain, no re-fetching happens. Only when a different domain is used, a new fetch request is triggered.

@bramkragten Do you think we need to add static caching to only retrieve the manifest once per integration (even if in between the user selects a different domain)? I would expect that usually a user is not wildly switching around the integrations when creating e.g. automations, so there should not be that many WS calls anyway.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

@bramkragten Do you think we need to add static caching to only retrieve the manifest once per integration (even if in between the user selects a different domain)? I would expect that usually a user is not wildly switching around the integrations when creating e.g. automations, so there should not be that many WS calls anyway.

Nah, don't think so

@bramkragten bramkragten enabled auto-merge (squash) September 6, 2021 08:47
@bramkragten bramkragten merged commit bc09feb into home-assistant:dev Sep 6, 2021
@spacegaier spacegaier deleted the issue-9919 branch September 6, 2021 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service call UI link to integration documentation is wrong for custom integrations
3 participants