Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent index access errors in entity quick bar #9964

Merged
merged 4 commits into from Sep 6, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Sep 5, 2021

Breaking change

Proposed change

After selection of an entity in the quickbar, the function _handleSelected() gets called twice. First with the real selection index and then a second time with -1. This PR prevents the invalid access attempts for -1.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

spacegaier and others added 2 commits September 6, 2021 10:38
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
bramkragten previously approved these changes Sep 6, 2021
@bramkragten bramkragten enabled auto-merge (squash) September 6, 2021 08:41
@bramkragten bramkragten merged commit 2bd9b5a into home-assistant:dev Sep 6, 2021
@spacegaier spacegaier deleted the issue-9952 branch September 6, 2021 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error is thrown when using the entity quick bar Shortcut bar causes error when started and closed
3 participants