Use unicode ellipsis instead of 3 dots "..." in user-facing strings

[Kisty]

Breaking change

Proposed change

Replace 3-dots ellipsis with Unicode's ellipsis character.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[Misiu]

I think we're not allowed to directly modify files with translations, but instead, the translations should be updated in https://lokalise.com/, according to the docs: https://developers.home-assistant.io/docs/translations.

[bramkragten]

Yes, only src/translations/en.json can be changed from this repo.

[Kisty]

OK, thanks for your help guys. How can I resolve this? I could send a CL with only en.json changing and do the other changes in Lokalise.

Can I edit all languages in Lokalise? Would I have to say I'm a translator of all languages, I guess?

[bramkragten]

Yes, you should have access to all languages if you signup

[spacegaier]

I am not sure if we can consistently use the Unicode. I assume in the future new translation strings will popup that use regular dots plus the community translations will not be consistent neither (most users will not know the difference).

That is why I had removed the few Unicode usages we had a couple of months ago 😎 so that we are indeed consistent visually in the frontend.

[Kisty]

I've gone through the translations in Lokalise and converted most of them to the single unicode character.

@spacegaier that's fair. Some translations did in fact have the single character already. I'll finish them up soon. Wasn't quite as easy as doing a search and replace in Lokalise!

[spacegaier]

Yes, it will be consistent now, but once we add new translation keys in the future, the community translations in lokalize will most likely use three dots, as most users are not aware that there is a dedicated Unicode symbol for it. Then the inconsistencies will start again.

To remain consistent the Github action that pulls in the lokalize translations into the frontend repo would need some logic to do an automatic conversion.

[Kisty]

That would be the dream automating it through GitHub Actions. There's possibly other characters that may be useful to auto convert to unicode counterparts like `'`, `"` to the angled ones though those would have complications because they have separate ones for open/closed and they're probably not even used anyway.

…

On Fri, 10 Sep 2021, 10:09 am Philip Allgaier, ***@***.***> wrote: Yes, it will be consistent now, but once we add new translation keys in the future, the community translations in lokalize will most likely use three dots, as most users are not aware that there is a dedicated Unicode symbol for it. Then the inconsistencies will start again. To remain consistent the Github action that pulls in the lokalize translations into the frontend repo would need some logic to do an automatic conversion. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9997 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYX52HVDG6J7JBAQYLU57LUBHDLZANCNFSM5DWZPBYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.