This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Moved user input to the top of the scripts. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landrash
suggested changes
Feb 12, 2018
| @@ -15,6 +15,13 @@ function appdaemon-install-package { | |||
| appdaemon-show-short-info | |||
| appdaemon-show-copyright-info | |||
|
|
|||
| if [ "$ACCEPT" != "true" ]; then | |||
| if [ -f "/usr/sbin/samba" ]; then | |||
| echo -n "Do you want to add samba share for AppDaemon configuration? [N/y] : " | |||
| echo | ||
| echo -e "\e[32mInstallation done..\e[0m" | ||
| echo | ||
| echo "You will find the appdaemon configuration files in:" |
There was a problem hiding this comment.
Formatting white space missing here and two line more.
There was a problem hiding this comment.
It's a "TAB" that's missing before the echo
There was a problem hiding this comment.
Yeah, I see that is missing, not sure how that happened :)
| echo | ||
| echo -e "\e[32mInstallation done..\e[0m" | ||
| echo | ||
| echo "You will find the appdaemon configuration files in:" |
There was a problem hiding this comment.
Appdaemon with Capital A?
| echo "Preparing system, and adding dependencies..." | ||
| sudo apt update | ||
| sudo apt -y upgrade | ||
| sudo apt install -y make git |
There was a problem hiding this comment.
Isn't git and make both installed in the base image?
| echo "" | ||
| echo "" | ||
| echo -n "Enter your Home Assistant API password: " | ||
| read -s HOMEASSISTANT_PASSWORD | ||
| echo | ||
| fi | ||
|
|
||
| if [ "$ACCEPT" != "true" ]; then | ||
| if [ -f "/usr/sbin/samba" ]; then | ||
| echo -n "Do you want to add samba share for Homebridge configuration? [N/y] : " |
| sudo apt install -y nodejs | ||
| sudo apt install -y libavahi-compat-libdnssd-dev | ||
|
|
||
| echo "Installing homebridge for homeassistant..." |
There was a problem hiding this comment.
Capital H for Homebridge, captial for Home Assistant and spelling for Home Assistant.
| fi | ||
| fi | ||
| if [ "$SAMBA" == "y" ] || [ "$SAMBA" == "Y" ]; then | ||
| echo "Adding configuration to samba..." |
| echo | ||
| echo "If you have issues with this script, please say something in the #devs_hassbian channel on Discord." | ||
| echo | ||
| echo |
There was a problem hiding this comment.
Formatting white space missing.
|
Found some more spelling errors :) |
Landrash
suggested changes
Feb 12, 2018
| @@ -80,7 +80,7 @@ if [ "$validation" != "0" ]; then | |||
| echo | |||
| echo -e "\e[32mInstallation done..\e[0m" | |||
| echo | |||
| echo "You will find the appdaemon configuration files in:" | |||
| echo "You will find the AppDaemon configuration files in:" | |||
| echo "/home/homeassistant/appdaemon" | |||
| @@ -80,7 +80,7 @@ if [ "$validation" != "0" ]; then | |||
| echo | |||
| echo -e "\e[32mInstallation done..\e[0m" | |||
| echo | |||
| echo "You will find the appdaemon configuration files in:" | |||
| echo "You will find the AppDaemon configuration files in:" | |||
| echo "/home/homeassistant/appdaemon" | |||
Landrash
approved these changes
Feb 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cosmetic change, so the user can go get a cup of coffee/tea while the script run, and not worry about it hanging waiting for input.
"If you have issues with this script, please say something in the #devs_hassbian channel on Discord."
This line will still print if the validation fail.
Related issue (if applicable): Fixes #108
Checklist:
If pertinent:
/docs