This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Hassbian-config: share-log errorhandling #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Mar 4, 2018
| a=$(cat $LOGFILE); curl -X POST -s -d "$a" https://hastebin.com/documents | awk -F '"' '{print "https://hastebin.com/"$4}' | ||
| loglink=$(curl -X POST -s -d "$(cat $LOGFILE)" https://hastebin.com/documents | awk -F '"' '{print "https://hastebin.com/"$4}') | ||
| if [[ $loglink != *"initial"* ]]; then | ||
| echo $loglink |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
| a=$(cat $LOGFILE); curl -X POST -s -d "$a" https://hastebin.com/documents | awk -F '"' '{print "https://hastebin.com/"$4}' | ||
| loglink=$(curl -X POST -s -d "$(cat $LOGFILE)" https://hastebin.com/documents | awk -F '"' '{print "https://hastebin.com/"$4}') | ||
| if [[ $loglink != *"initial"* ]]; then | ||
| echo $loglink |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
Landrash
suggested changes
Mar 7, 2018
| if [[ $loglink != *"initial"* ]]; then | ||
| echo "$loglink" | ||
| else | ||
| echo "There is an issue with your network conection, or with the hastebin API.." |
| @@ -80,17 +80,35 @@ function check-permission { | |||
| } | |||
|
|
|||
| function share-log { | |||
| if [ ! -f $LOGFILE ];then | |||
| echo "No logfile exiting..." | |||
There was a problem hiding this comment.
Missing comma.
No logfile, exiting.
| echo "$loglink" | ||
| else | ||
| echo | ||
| echo "There is an issue with your network conection, or with the hasebin API.." |
There was a problem hiding this comment.
Spelling:
"There is an issue with your network connection, or with the Hastebin API."
Fix spelling
Landrash
approved these changes
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This will better handle errors if hastebin is down.
Compare:
Old:
New:
Checklist:
If pertinent:
/docs