Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Change Appdaemon's default conf #140

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Conversation

cxlwill
Copy link
Contributor

@cxlwill cxlwill commented Mar 22, 2018

Since Appdaemon v3 officially published, then we should change the default conf to meet with new format.

Description:

Related issue (if applicable): Fixes #

Checklist:

  • The code change is tested and works locally.
  • Script has validation check of the job.

If pertinent:

  • Created/Updated documentation at /docs

Since Appdaemon v3 officially published, then we should change the default `conf` to meet with new format.
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, other than that it looks good.

type: hass
ha_url: http://127.0.0.1:8123
ha_key:
Copy link
Member

@ludeeus ludeeus Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment out the key part?
If you see #142 it still fails if the ha_key: is blank..
#ha_key:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the issue. Did it mean that we should add latitude longitude time_zone... conf by default? But I search Appdaemon’s docs and these variables should be optional.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is necessary, If you change ha_key: to #ha_key: it will start.
I'm working on setting the password if one is supplied in the script now.

@ludeeus ludeeus self-assigned this Mar 23, 2018
@ludeeus ludeeus added this to the v0.8.1 milestone Mar 23, 2018
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :) thank you 🥇

@ludeeus ludeeus removed their assignment Mar 23, 2018
@Landrash Landrash merged commit a515e91 into home-assistant:dev Mar 23, 2018
@cxlwill cxlwill deleted the patch-1 branch April 3, 2018 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants