Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit UI - Can't edit object after ESC #2331

Closed
nunofmds opened this issue Dec 15, 2018 · 5 comments
Closed

Edit UI - Can't edit object after ESC #2331

nunofmds opened this issue Dec 15, 2018 · 5 comments

Comments

@nunofmds
Copy link

nunofmds commented Dec 15, 2018

Home Assistant release with the issue:

0.84.2

Last working Home Assistant release (if known):
None. This is new feature, edit object directly on browser.

Browser and Operating System:

Google Chrome - Windows 10 Latest

Description of problem:

When using the Edit UI, after click on edit object it opens but if you click ESC you can't edit it again until you refresh the browser contents. If you press edit after the ESC nothing happens.
If on other way the cancel it's clicked then everything works as expected and it's possible do edit object again.
I guess ESC is exiting the edit mode globally and no only the object being edited.

Javascript errors shown in the web inspector (if applicable):


Additional information:
image

@iantrich
Copy link
Member

I can't replicate this on Windows 10 - Chrome

@nunofmds
Copy link
Author

I can't replicate this on Windows 10 - Chrome

1 - Try to edit any object you have
2 - Press ESC key
3 - Try to edit it again... it will not open if you click edit

@nunofmds
Copy link
Author

nunofmds commented Dec 16, 2018

issue

As you can see when I click cancel I can open it again...if I use ESC it will not open anymore until I refresh the page...

@iantrich
Copy link
Member

I did exactly that and it worked fine. ¯_(ツ)_/¯

@balloob
Copy link
Member

balloob commented Dec 16, 2018

I fixed this in dev. #2290

@balloob balloob closed this as completed Dec 16, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants