Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dev-info page #2624

Merged
merged 9 commits into from
Jan 29, 2019
Merged

Refactor dev-info page #2624

merged 9 commits into from
Jan 29, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 29, 2019

Clean up the dev-info page in preparation of adding system health info:

  • Convert to TS/Lit
  • Break up into standalone components

@ghost ghost assigned balloob Jan 29, 2019
@ghost ghost added the in progress label Jan 29, 2019
iantrich
iantrich reviewed Jan 29, 2019
View reviewed changes
src/panels/dev-info/ha-panel-dev-info.ts Outdated
<app-toolbar>
<ha-menu-button .narrow='${this.narrow}' showMenu='${
this.showMenu
}'></ha-menu-button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint?

@iantrich @balloob
Apply suggestions from code review
27e8fa9 
Co-Authored-By: balloob <paulus@home-assistant.io>
iantrich
iantrich reviewed Jan 29, 2019
View reviewed changes
src/panels/dev-info/ha-panel-dev-info.ts Outdated
</p>
<p>
<a href="${nonDefaultLink}">${nonDefaultLinkText}</a>
<div id="love" style="cursor:pointer;" @click="${
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to styles()

@iantrich @balloob
Apply suggestions from code review
5e1eb5a 
Co-Authored-By: balloob <paulus@home-assistant.io>
balloob and others added 3 commits January 29, 2019 15:03
@balloob
TSC
8456dbc
@iantrich @balloob
Apply suggestions from code review
b5de043 
Co-Authored-By: balloob <paulus@home-assistant.io>
@balloob
TSC
659b09b
@balloob balloob merged commit c964ea3 into dev Jan 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the dev-info-cleanup branch January 29, 2019 23:34
@ghost ghost removed the in progress label Jan 29, 2019
@balloob balloob mentioned this pull request Jan 31, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iantrich iantrich iantrich left review comments

Assignees

@balloob balloob

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balloob @iantrich @homeassistant