Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant text in Cloud panel #3824 #3967

Merged
merged 1 commit into from Oct 11, 2019

Conversation

shmooey
Copy link
Contributor

@shmooey shmooey commented Oct 9, 2019

This fixes #3824

image

@homeassistant
Copy link
Contributor

Hi @shmooey,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@iantrich iantrich added this to the 0.101 milestone Oct 10, 2019
@bramkragten
Copy link
Member

Should we remove this or rephrase, I think it can be helpful for people to know what kind of devices are Alexa/Google Assistant-enabled?

@SeanPM5
Copy link
Contributor

SeanPM5 commented Oct 10, 2019

My line of thinking was:

  • These cards are getting a little bit crowded/cluttered now and this text seems entirely unnecessary
  • The text on the first line ("via any Alexa-enabled device") should already make it clear that all devices are supported. It's hard to misinterpret "any Alexa-enabled device" but once you start listing specific devices under that, I feel like that muddies the water a bit.
  • If we start listing specific models, then people are just going to get confused when their model isn't listed. "It says Echo Dot, but I have an Echo Show, am I unsupported? What about this Echo Studio they just announced? Echo Flex?"

I think removing it cleans up the card a little and also reduces any possibility for confusion.

@bramkragten bramkragten removed this from the 0.101 milestone Oct 11, 2019
Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds reasonable

@bramkragten bramkragten merged commit 6f7ea03 into home-assistant:dev Oct 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant text in Cloud panel
5 participants