Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiffi also suitable for LAN devices #26089

Closed
heinrich2808 opened this issue Feb 3, 2023 · 3 comments · Fixed by home-assistant/core#87798
Closed

wiffi also suitable for LAN devices #26089

heinrich2808 opened this issue Feb 3, 2023 · 3 comments · Fixed by home-assistant/core#87798

Comments

@heinrich2808
Copy link

Feedback

The software developper of the wiffi add-on is using a weatherman device - a kit purchased fm stall.buiz and an interesting
solution. But it is also important to note: data transmission fm the weatherman to the homeassistant is done via WLAN.
When I installed the Pulsecounter-LAN2 (also fm stall.buiz) to be connected to the homeassistant my idea was to use this
wiffi add-on - but it doesn't work`` with the following error message:

Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/wiffi/init.py", line 224, in call
await self.parse_msg(peername, data[:-1]) # omit separator with [:-1]
File "/usr/local/lib/python3.10/site-packages/wiffi/init.py", line 240, in parse_msg
metrics.append(WiffiMetricFromSystemInfo("rssi", "dBm", "number", data["Systeminfo"]["WLAN_Signal_dBm"]))
KeyError: 'WLAN_Signal_dBm'

Pls note: I am a newbie as homeassistant as well as software dev. is concerned, but my idea is:

The pulsecounter is connected to my network/homeassistant via LAN (and not via WLAN as the weatherman).
As the wiffi add-on is concerned: the add-on is waiting for an information as the WLAN signal strengh is concerned

  • and as long as this info is missing the wiffi addon will not work with with the pulscounter. It is a pity

It would be great if mampfes could append a "switch" in his wiffi addon to make it suitable also for wiffi LAN devices

URL

https://www.home-assistant.io/integrations/wiffi/

Version

2023.2.1

Additional information

used homeassistant version
HASS

@home-assistant
Copy link

home-assistant bot commented Feb 3, 2023

Hey there @mampfes, mind taking a look at this feedback as it has been labeled with an integration (wiffi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wiffi can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign wiffi Removes the current integration label and assignees on the issue, add the integration domain after the command.

mampfes added a commit to mampfes/home-assistant that referenced this issue Feb 4, 2023
fix home-assistant/home-assistant.io#26089

wiffi 1.1.1 adds support for LAN based Wiffi devices. It doesn't presume
the attributes `rssi` and `ssid` anymore.
@heinrich2808
Copy link
Author

Hi,
is my idea ok: I deactivate + delete the wiffi integration which I have downloaded two weeks ago and I reinstalled
the wiffi fim the github in order to get the wiffi 1.1.2 ?

Because this is exactly what I did and still I face the same error log as before:

Traceback (most recent call last): File "/usr/local/lib/python3.10/site-packages/wiffi/__init__.py", line 224, in __call__ await self.parse_msg(peername, data[:-1]) # omit separator with [:-1] File "/usr/local/lib/python3.10/site-packages/wiffi/__init__.py", line 240, in parse_msg metrics.append(WiffiMetricFromSystemInfo("rssi", "dBm", "number", data["Systeminfo"]["WLAN_Signal_dBm"])) KeyError: 'WLAN_Signal_dBm'

Also I would have anticipated a kind of switch to select wiffi via WLAN - LAN ?

Almost useless to say I am absolutely unexperienced as python and yaml is conecerned, hence I appreciate
your efforts in context with wiffi....

@mampfes
Copy link
Contributor

mampfes commented Feb 7, 2023

I think this will not work, because HA always uses the configured package version. This also corresponds to what you can see in the log: In version 1.1.2 this line from the log is in line 241.

There are some advices in the HA developer docu how to use different version for packages like wiffi: https://developers.home-assistant.io/docs/creating_integration_manifest#custom-requirements-during-development--testing

It would be great if you could test this before I (re)open the PR in the HA main repo.

mampfes added a commit to mampfes/home-assistant that referenced this issue Feb 7, 2023
fix home-assistant/home-assistant.io#26089

wiffi 1.1.1 adds support for LAN based Wiffi devices. It doesn't presume
the attributes `rssi` and `ssid` anymore.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants