Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates pi_hole component documentation #10097

Merged
merged 1 commit into from Sep 4, 2019
Merged

Updates pi_hole component documentation #10097

merged 1 commit into from Sep 4, 2019

Conversation

johnluetke
Copy link
Contributor

@johnluetke johnluetke commented Aug 10, 2019 •
edited by gitpod-io bot

Description:

Pull request in home-assistant: home-assistant/core#25837

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@johnluetke johnluetke mentioned this pull request Aug 10, 2019
Merged
9 tasks
@klaasnicolaas klaasnicolaas changed the title Updates pi_hole component documentation per home-assistant/home-assis… Updates pi_hole component documentation Aug 10, 2019
@klaasnicolaas klaasnicolaas added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch ready-for-review This PR needs to be reviewed labels Aug 10, 2019
@klaasnicolaas klaasnicolaas added this to To Do in New documentation via automation Aug 10, 2019
frenck
frenck approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

New documentation automation moved this from To Do to Awaiting Parent PR Sep 2, 2019
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Sep 2, 2019
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Sep 3, 2019
@klaasnicolaas klaasnicolaas merged commit 20ed56e into home-assistant:next Sep 4, 2019
New documentation automation moved this from Awaiting Parent PR to Done Sep 4, 2019
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Sep 4, 2019
@klaasnicolaas
Copy link
Member

Thnx for the PR! 👍

@klaasnicolaas klaasnicolaas removed the awaits-parent Awaits the merge of an parent PR label Sep 4, 2019
@johnluetke johnluetke deleted the refactor-pihole-integration branch September 22, 2019 02:23
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

@klaasnicolaas klaasnicolaas klaasnicolaas approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnluetke @klaasnicolaas @frenck