Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'availability_template' to all Template Lock platform #10307

Merged
merged 4 commits into from Oct 2, 2019
Merged

Added 'availability_template' to all Template Lock platform #10307

merged 4 commits into from Oct 2, 2019

Conversation

grillp
Copy link
Contributor

@grillp grillp commented Sep 8, 2019

Added documentation availability_template configuration option for Template Lock platform components.

home-assistant/core#26517

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Sep 8, 2019
This was referenced Sep 8, 2019
Merged
Closed
@frenck frenck added in-progress This PR/Issue is currently being worked on new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Sep 10, 2019
frenck
frenck requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @grillp (and thanks for splitting). I've reviewed it and left some comments. Could you please take a look?

source/_components/lock.template.markdown Outdated Show resolved Hide resolved
source/_components/lock.template.markdown Outdated Show resolved Hide resolved
@frenck frenck added this to To Do in New documentation via automation Sep 10, 2019
@frenck frenck moved this from To Do to In Progress in New documentation Sep 10, 2019
New documentation automation moved this from In Progress to Awaiting Parent PR Sep 11, 2019
frenck
frenck previously approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Sep 11, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Oct 1, 2019
@frenck frenck moved this from Awaiting Parent PR to Parent Merged in New documentation Oct 1, 2019
@frenck frenck self-assigned this Oct 2, 2019
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 2, 2019
New documentation automation moved this from Parent Merged to Awaiting Parent PR Oct 2, 2019
frenck
frenck approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @grillp! 🎉

@frenck frenck merged commit 4688830 into home-assistant:next Oct 2, 2019
New documentation automation moved this from Awaiting Parent PR to Done Oct 2, 2019
@probot-home-assistant probot-home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Oct 2, 2019
@frenck frenck removed the awaits-parent Awaits the merge of an parent PR label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees

@frenck frenck

Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grillp @frenck