Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flow to iCloud #11259

Merged
merged 4 commits into from
Dec 9, 2019
Merged

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Nov 22, 2019

Description:

Following home-assistant/core#28968

Pull request in home-assistant: home-assistant/core#28968

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Nov 22, 2019
@Quentame Quentame marked this pull request as ready for review November 22, 2019 23:19
@Quentame
Copy link
Member Author

Quentame commented Dec 4, 2019

@klaasnicolaas can you take a look ?

The parent PR is almost ready 😊

Thanks

@klaasnicolaas klaasnicolaas added this to To Do in New documentation via automation Dec 4, 2019
@frenck
Copy link
Member

frenck commented Dec 5, 2019

@Quentame Please don't tag random members to ask for a review. Thanks 👍

Regarding this PR, it will get a review before the release the parent PR is in for sure. 👍

@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Dec 5, 2019
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Dec 9, 2019
@project-bot project-bot bot moved this from To Do to Parent Merged in New documentation Dec 9, 2019
@frenck
Copy link
Member

frenck commented Dec 9, 2019

@Quentame Adjusted (and moved it a bit).

New documentation automation moved this from Parent Merged to Awaiting Parent PR Dec 9, 2019
@frenck frenck merged commit 9cd1835 into home-assistant:next Dec 9, 2019
New documentation automation moved this from Awaiting Parent PR to Done Dec 9, 2019
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Dec 9, 2019
@Quentame Quentame deleted the icloud/config-flow branch December 9, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants