Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs with instructions on using config flow to pair vizio devices and update integration name #11988

Merged
merged 8 commits into from Mar 2, 2020
Merged

Update docs with instructions on using config flow to pair vizio devices and update integration name #11988

merged 8 commits into from Mar 2, 2020

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Feb 6, 2020

Proposed change

Added a pairing workflow to the config flow for the vizio integration so the docs have been updated to reflect the change. I also changed the integration name to remove "TV" because soundbars are supported as well

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Feb 6, 2020
@raman325 raman325 mentioned this pull request Feb 6, 2020
Merged
20 tasks
@klaasnicolaas klaasnicolaas added this to To Do in New documentation via automation Feb 6, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Feb 10, 2020
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Feb 28, 2020
@project-bot project-bot bot moved this from To Do to Parent Merged in New documentation Feb 28, 2020
New documentation automation moved this from Parent Merged to Awaiting Parent PR Mar 2, 2020
@frenck frenck merged commit d85b66b into home-assistant:next Mar 2, 2020
New documentation automation moved this from Awaiting Parent PR to Done Mar 2, 2020
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Mar 2, 2020
@raman325 raman325 deleted the vizio_add_pairing_to_config_flow branch March 3, 2020 08:04
zsarnett pushed a commit to zsarnett/home-assistant.io that referenced this pull request Mar 3, 2020
@raman325 @frenck @zsarnett
Update docs with instructions on using config flow to pair viz… (home…
55b9afa 
…-assistant#11988)

* update docs to reflect changes to pairing workflow

* formatting and phrasing

* add CLI script as a pairing option

* update text for clarity

* changes based on comments

* fix lint issue

* ✏️ Tweaks

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLIrion JeffLIrion JeffLIrion left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raman325 @frenck @JeffLIrion