Add sound mode support #4470

starkillerOG · 2018-01-20T10:17:15Z

Description:

Two aditional configuration options: sound_mode and sound_mode_dict
Aditional service: media_player/select_sound_mode

Front end pull request: home-assistant/frontend#815

Pull request in home-assistant (if applicable): home-assistant/core#13706

Checklist:

Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
The documentation follow the standards.

- this time with the next branch as base

Added the documentation for the new general sound mode support service. General basis is there for all platforms, but only the Denon AVR component is currently implemented (first release).

frenck

@starkillerOG I've reviews the docs and left some comments. Could you please take a look? Thx already! 👍

frenck · 2018-01-20T15:20:52Z

source/_components/media_player.denonavr.markdown

@@ -48,6 +48,8 @@ media_player:
    name: NAME
    show_all_sources: True / False
    timeout: POSITIVE INTEGER
+    sound_mode: True


We are trying to keep the examples as minimal as possible. Please remove the added optional configuration paramters.

I removed the sound_mode. But I would like to keep the sound_mode_dict in the example because this is a somewhat difficult parameter, for example if you put " " around it and make it a string it will not work anymore. And if I remember corectly the values in this dict schould be uppercase, otherwise the values received from the AVR will not match. And a dictionary is in general a little more difficult then just a string or a number for the basic users.

Furthermore the hole zones parameter is also in the example and you do not need that in general and is also optional if you don't use second zones on your AVR.

frenck · 2018-01-20T15:22:02Z

source/_components/media_player.denonavr.markdown

@@ -59,6 +61,8 @@ Configuration variables:
 - **name** (*Optional*): Name of the device. If not set, friendlyName of receiver is used.
 - **show_all_sources** (*Optional*): If True all sources are displayed in sources list even if they are marked as deleted in the receiver. If False deleted sources are not displayed (default). Some receivers have a bug that marks all sources as deleted in the interface. In this case this option could help.
 - **timeout** (*Optional*): Timeout for HTTP requests to the receiver. Defaults to 2 seconds if not provided.
+- **sound_mode** (*Optional*)(*boolean*): Flag that defines if sound mode is supported. Default value: True.
+- **sound_mode_dict** (*Optional*): Dictonary containing the sound modes that are supported, the key needs to be identical with the command to set a specific sound mode and the corresponding value needs to be the sound mode as reported by the AVR. Default value: {'MUSIC':'PLII MUSIC', 'MOVIE':'PLII MOVIE', 'GAME':'PLII GAME', 'PURE DIRECT':'DIRECT', 'AUTO':'None', 'DOLBY DIGITAL':'DOLBY DIGITAL', 'MCH STEREO':'MULTI CH STEREO', 'STEREO':'STEREO'}


Dictonary -> Dictionary

Thanks for checking my bad spelling

frenck · 2018-01-20T15:22:41Z

source/_components/media_player.denonavr.markdown

@@ -68,5 +72,6 @@ A few notes:
 - Additional option the control Denon AVR receivers with a builtin web server is using the HTTP interface with denonavr platform.
 - denonavr platform supports some additional functionalities like album covers, custom input source names and auto discovery.
 - Marantz receivers seem to a have quite simliar interface. Thus if you own one, give it a try.
+- The key-value structure in the sound_mode_dict is needed because the commands to set an sound mode and the reported sound mode are diffrent. This structure matches the reported sound mode with the commands to set a sound mode.


diffrent -> different

Backquote sound_mode_dict keyword

How do you make a backquote in this "code"?

- fixed some spelling mistakes

starkillerOG · 2018-01-20T15:40:11Z

@frenck Thanks for your review, I made changes based on your comments.
Could you maybe also look at the backend and frontend pull request for this sound mode support?
Front end: home-assistant/frontend#815
Back end: home-assistant/core#11764

frenck · 2018-01-20T16:00:11Z

Thanks for the adjustments @starkillerOG 🎖
This PR can be merged as soon as both parent PRs have been merged.

I'm sorry but I do not review those type of PRs.

starkillerOG · 2018-01-20T16:47:49Z

@frenck could you check your request for changes as addressed, so the red cross will go away and it can be merged once the other 2 PR's are accepted?

frenck · 2018-01-20T17:42:39Z

@starkillerOG Sorry simply forgot to hit the approve button, my bad... 🤦‍♂️

stale · 2018-03-21T17:58:52Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

starkillerOG · 2018-03-22T09:10:21Z

Still waiting until my PR of the denonavr library is merged.

frenck

@starkillerOG Could you please take a look at the merge conflicts?

starkillerOG · 2018-03-26T12:35:01Z

@frenck I think I resolved the conflict, but I am still waiting until the backend code can be merged.

starkillerOG · 2018-04-05T20:00:44Z

@frenck I think I might have undone your changes, sorry I just wanted to correct the syntax.
Can you do the changes again?
Sorry.

starkillerOG · 2018-04-06T17:16:46Z

Thank you @frenck

frenck · 2018-04-06T17:25:28Z

No! Thank you 👍

frenck · 2018-05-30T10:11:02Z

Closing this PR, since the parent PR has been closed as well.

starkillerOG added 2 commits January 20, 2018 11:03

Add sound mode support

cfc6c0e

- this time with the next branch as base

Add sound mode service

18e3a6a

Added the documentation for the new general sound mode support service. General basis is there for all platforms, but only the Denon AVR component is currently implemented (first release).

This was referenced Jan 20, 2018

Add sound mode support #4453

Closed

Add sound mode support (media_player frontend) home-assistant/frontend#815

Closed

Sound mode support media_player general and denonavr home-assistant/core#11764

Closed

frenck requested changes Jan 20, 2018

View reviewed changes

frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jan 20, 2018

Sound mode support

bc89385

- fixed some spelling mistakes

frenck approved these changes Jan 20, 2018

View reviewed changes

stale bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Mar 21, 2018

stale bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Mar 22, 2018

frenck self-assigned this Mar 23, 2018

frenck requested changes Mar 23, 2018

View reviewed changes

frenck assigned starkillerOG and unassigned frenck Mar 23, 2018

Merge branch 'next' into patch-3

e9ff0dc

frenck previously approved these changes Apr 2, 2018

View reviewed changes

starkillerOG mentioned this pull request Apr 5, 2018

Sound mode support media_player general and denonavr home-assistant/core#13706

Closed

8 tasks

Add sound mode support: Update syntax

5e90592

starkillerOG dismissed frenck’s stale review via 5e90592 April 5, 2018 19:53

frenck self-assigned this Apr 6, 2018

✏️ Several language tweaks

9bf4128

frenck approved these changes Apr 6, 2018

View reviewed changes

frenck unassigned frenck and starkillerOG Apr 6, 2018

frenck closed this May 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sound mode support #4470

Add sound mode support #4470

starkillerOG commented Jan 20, 2018 •

edited

Loading

frenck left a comment

frenck Jan 20, 2018

starkillerOG Jan 20, 2018

frenck Jan 20, 2018

starkillerOG Jan 20, 2018

frenck Jan 20, 2018

starkillerOG Jan 20, 2018

starkillerOG commented Jan 20, 2018

frenck commented Jan 20, 2018

starkillerOG commented Jan 20, 2018

frenck commented Jan 20, 2018

stale bot commented Mar 21, 2018

starkillerOG commented Mar 22, 2018

frenck left a comment

starkillerOG commented Mar 26, 2018

starkillerOG commented Apr 5, 2018

starkillerOG commented Apr 6, 2018

frenck commented Apr 6, 2018

frenck commented May 30, 2018

Add sound mode support #4470

Add sound mode support #4470

Conversation

starkillerOG commented Jan 20, 2018 • edited Loading

Checklist:

frenck left a comment

Choose a reason for hiding this comment

frenck Jan 20, 2018

Choose a reason for hiding this comment

starkillerOG Jan 20, 2018

Choose a reason for hiding this comment

frenck Jan 20, 2018

Choose a reason for hiding this comment

starkillerOG Jan 20, 2018

Choose a reason for hiding this comment

frenck Jan 20, 2018

Choose a reason for hiding this comment

starkillerOG Jan 20, 2018

Choose a reason for hiding this comment

starkillerOG commented Jan 20, 2018

frenck commented Jan 20, 2018

starkillerOG commented Jan 20, 2018

frenck commented Jan 20, 2018

stale bot commented Mar 21, 2018

starkillerOG commented Mar 22, 2018

frenck left a comment

Choose a reason for hiding this comment

starkillerOG commented Mar 26, 2018

starkillerOG commented Apr 5, 2018

starkillerOG commented Apr 6, 2018

frenck commented Apr 6, 2018

frenck commented May 30, 2018

starkillerOG commented Jan 20, 2018 •

edited

Loading